[ 
https://issues.apache.org/jira/browse/LUCENE-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738029#action_12738029
 ] 

Michael Busch commented on LUCENE-1775:
---------------------------------------

Hi Uwe,

I just noticed your comment after I attached the latest patch...

There's probably a better way to do it. Feel free to update the patch ;)
My brain is tired and I really need to sleep now...

I used the same trick in the Prefix/Suffix filters - one of the reasons I did 
it in those filters is it to not change the updateSuffixToken(Token, Token) 
method, which I assume is there so that users can overwrite it.

> Change org.apache.lucene.analysis.shingle to use new TokenStream API
> --------------------------------------------------------------------
>
>                 Key: LUCENE-1775
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1775
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: contrib/analyzers
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: lucene-1775.patch, lucene-1775.patch, lucene-1775.patch, 
> lucene-1775.patch
>
>
> All other contrib streams/filters have already been converted with 
> LUCENE-1460.
> The two shingle filters are the last ones we need to convert.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to