[ 
https://issues.apache.org/jira/browse/LUCENE-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738325#action_12738325
 ] 

Robert Muir commented on LUCENE-1775:
-------------------------------------

Michael, I looked at your patch, really glad you were successful here!

One last question, we didnt do anything with analysis/sinks 
(DateRecognizerSinkTokenizer, etc). 
These are deprecated as they extend SinkTokenizer... will they be removed with 
the old api or do we need to implement alternatives?


> Change org.apache.lucene.analysis.shingle to use new TokenStream API
> --------------------------------------------------------------------
>
>                 Key: LUCENE-1775
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1775
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: contrib/analyzers
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: lucene-1775.patch, lucene-1775.patch, lucene-1775.patch, 
> lucene-1775.patch
>
>
> All other contrib streams/filters have already been converted with 
> LUCENE-1460.
> The two shingle filters are the last ones we need to convert.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to