[ 
https://issues.apache.org/jira/browse/LUCENE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738840#action_12738840
 ] 

Nick Pellow commented on LUCENE-1769:
-------------------------------------

Hi Hoss, 

{quote}
Nick: if i'm understanding this comment correctly you are implying...

* that you represent Atlassian and are offering an updated license to use 
clover 2.x
* that Atlassian will allow us to make this license available for anyone, 
anywhere in the world, to use when building/developing Lucene (regardless of 
what their affiliation is with the ASF)
{quote}

Correct on both counts, except the updated license will only work with the 
upcoming release of Clover 2.6, and onwards.

bq. The README files associated with the licenses don't contain any specific 
instructions either way, so the location in "private/committers" suggests it's 
access restrictions

I can't comment on that clover license. It may well need to stay in the private 
repo.

{quote}
If we truly can make both the license publicly available then we could simplify 
a lot of things by commiting clover.license into the source tree
{quote}

That is exactly the idea. The license will also work inside the Clover IDEA and 
Eclipse plugins for anyone, anywhere developing on org.apache projects.
If you don't wish to check the clover.jar into subversion, the clover.jar can 
always be downloaded directly from the maven central repository: 
http://repo2.maven.org/maven2/com/cenqua/clover/clover/ (when version 2.6.0 
arrives ;) .

So, to move forward:
* I will have an email sent to  java-...@lucene spelling out exactly how the 
license can be used/disseminated
* I will get you an EAP of Clover 2.6 with the upgraded licensing code
* I will also attach a copy of the new Clover Apache Site license to this 
ticket for someone to commit to your repository.

Please let me know if there is anything we can do, or if you have any further 
questions/suggestions!

Cheers,
Nick


> Fix wrong clover analysis because of backwards-tests, upgrade clover to 2.4.3 
> or better
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1769
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1769
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.9
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-1769.patch, LUCENE-1769.patch, 
> nicks-LUCENE-1769.patch
>
>
> This is a followup for 
> [http://www.lucidimagination.com/search/document/6248d6eafbe10ef4/build_failed_in_hudson_lucene_trunk_902]
> The problem with clover running on hudson is, that it does not instrument all 
> tests ran. The autodetection of clover 1.x is not able to find out which 
> files are the correct tests and only instruments the backwards test. Because 
> of this, the current coverage report is only from the backwards tests running 
> against the current Lucene JAR.
> You can see this, if you install clover and start the tests. During test-core 
> no clover data is added to the db, only when backwards-tests begin, new files 
> are created in the clover db folder.
> Clover 2.x supports a new ant task, <testsources> that can be used to specify 
> the files, that are the tests. It works here locally with clover 2.4.3 and 
> produces a really nice coverage report, also linking with test files work, it 
> tells which tests failed and so on.
> I will attach a patch, that changes common-build.xml to the new clover 
> version (other initialization resource) and tells clover where to find the 
> tests (using the test folder include/exclude properties).
> One problem with the current patch: It does *not* instrument the backwards 
> branch, so you see only coverage of the core/contrib tests. Getting the 
> coverage also from the backwards tests is not easy possible because of two 
> things:
> - the tag test dir is not easy to find out and add to <testsources> element 
> (there may be only one of them)
> - the test names in BW branch are identical to the trunk tests. This 
> completely corrupts the linkage between tests and code in the coverage report.
> In principle the best would be to generate a second coverage report for the 
> backwards branch with a separate clover DB. The attached patch does not 
> instrument the bw branch, it only does trunk tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to