On Tue, Aug 4, 2009 at 11:46 AM, Yonik Seeley<yo...@lucidimagination.com> wrote: > On Tue, Aug 4, 2009 at 11:34 AM, Michael > McCandless<luc...@mikemccandless.com> wrote: >> On Tue, Aug 4, 2009 at 11:29 AM, Yonik Seeley<yo...@lucidimagination.com> >> wrote: >> >>>> In fact I think SortField.getComparator should be package private? >>> >>> It would be nice to keep - Solr already uses it :-) >> >> Intersting! OK I'll leave it public but put "subject to suddenly >> change" warning on it. > > Sure. Using that method allowed me to delete a lot of SortComparator > code that was previously copy-n-pasted from Lucene into Solr. > > Solr is basically using the comparators to get the sort field values > to return during distributed search, so docs can be merged. Yes, we > should be able to get that from FieldDoc... but that would require a > number of changes to the APIs, and also to caching.
OK got it. I'll post a patch soon... Mike --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
