[
https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739333#action_12739333
]
Adriano Crestani commented on LUCENE-1782:
------------------------------------------
I really liked the idea Mike!
If QueryParser is under "standard", so it's the standard QueryParser. Makes
sense, so, I would like to suggest to do the same for:
-OriginalBooleanQueryNodeBuilder
-OriginalQueryBuilder
-OriginalBooleanQueryTreeBuilder
-OriginalQueryConfigHandler
-OriginalBooleanQueryNode
-OriginalSyntaxParser (and all the other classes generated by JavaCC)
-OriginalQueryNodeProcessorPipeline
And you are right, "default" cannot be used for a package name, I just double
checked that. I think "standard" is fine too :)
> Rename OriginalQueryParserHelper
> --------------------------------
>
> Key: LUCENE-1782
> URL: https://issues.apache.org/jira/browse/LUCENE-1782
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
