[
https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1782:
---------------------------------------
Attachment: LUCENE-1782.patch
Attached enormous patch.
It's much simpler than it looks... I used "svn move" to shuffle
everything around, replaced "original" with "standard" everywhere,
renamed StandardQueryParserHelper to simply QueryParser, and stripped
Standard prefix off a bunch of classes. I also had to fix a handful
of places that dealt with both the core & standard versions of the
same class, by fully qualifying the core one.
One class (StandardBooleanQueryNodeBuilder) had to keep its Standard
prefix because BooleanQueryNodeBuilder was also in the same package.
The patch also add the "javacc" target to build.xml, and a comment
explaining about ParseException.java.
> Rename OriginalQueryParserHelper
> --------------------------------
>
> Key: LUCENE-1782
> URL: https://issues.apache.org/jira/browse/LUCENE-1782
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1782.patch
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
