[
https://issues.apache.org/jira/browse/LUCENE-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740328#action_12740328
]
Hoss Man edited comment on LUCENE-1789 at 8/7/09 7:16 AM:
----------------------------------------------------------
This idea orriginated in LUCENE-1749, see these comments...
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740155#action_12740155
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740256#action_12740256
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740278#action_12740278
I've marked this for 2.9 for now .... i think it's a "nice to have" in 2.9,
because unlike general FieldCache usage, the API is abstract enough we can
protect our users from mistakes; but i don't personally think it's critical
that we do this if no one else wants to take a stab at it.
(EDIT: shorter versions of URLs to prevent horizontal scroll)
was (Author: hossman):
This idea orriginated in LUCENE-1749, see these comments...
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740155&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12740155
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740256&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12740256
https://issues.apache.org/jira/browse/LUCENE-1749?focusedCommentId=12740278&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12740278
I've marked this for 2.9 for now .... i think it's a "nice to have" in 2.9,
because unlike general FieldCache usage, the API is abstract enough we can
protect our users from mistakes; but i don't personally think it's critical
that we do this if no one else wants to take a stab at it.
> getDocValues should provide a MultiReader DocValues abstraction
> ---------------------------------------------------------------
>
> Key: LUCENE-1789
> URL: https://issues.apache.org/jira/browse/LUCENE-1789
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Fix For: 2.9
>
>
> When scoring a ValueSourceQuery, the scoring code calls
> ValueSource.getValues(reader) on *each* leaf level subreader -- so DocValue
> instances are backed by the individual FieldCache entries of the subreaders
> -- but if Client code were to inadvertently called getValues() on a
> MultiReader (or DirectoryReader) they would wind up using the "outer"
> FieldCache.
> Since getValues(IndexReader) returns DocValues, we have an advantage here
> that we don't have with FieldCache API (which is required to provide direct
> array access). getValues(IndexReader) could be implimented so that *IF* some
> a caller inadvertently passes in a reader with non-null subReaders, getValues
> could generate a DocValues instance for each of the subReaders, and then wrap
> them in a composite "MultiDocValues".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
