[ 
https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-1794:
--------------------------------

    Attachment: LUCENE-1794.patch

add reusable/reset impls for shingles, snowball, and memory/synonym.
memory/synonym had no previous tests afaik.
tests are still needed for compound,ngram, and shingles reset()
memory/PatternAnalyzer still does not use reusableTS
and there are two wrappers: shingle/ShingleAnalyzerWrapper and 
query/QueryAutoStopWordAnalyzer that should be fixed and tested.

unfortunately something came up at work, so I may be slow on this, if you want 
to jump in, please help!
and let me know what you are tackling, I will do my best to work this issue 
late night to get it resolved.


> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>
>                 Key: LUCENE-1794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1794
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch, 
> LUCENE-1794.patch
>
>
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed, 
> I think we should do this to mitigate any performance costs. hey, overall it 
> might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is 
> easy money in my opinion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to