[
https://issues.apache.org/jira/browse/LUCENE-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743421#action_12743421
]
Mark Miller commented on LUCENE-1808:
-------------------------------------
bq. it could have saved me a lot of time creating this QueryWeight replacement
And it would have saved me time reverting and making it an abstract class -
what can you do though? If we could have kept back compat here, I think we
would have - but we didn't find a good way that avoided the issues we faced.
I think there was a user that picked up a back compat break with QueryWeight
anyway - a method he could override wasn't being called anymore? So its prob
for the best - things are always changing, and new info / tradeoffs always come
up.
> make Query.createWeight public (or add back Query.createQueryWeight())
> ----------------------------------------------------------------------
>
> Key: LUCENE-1808
> URL: https://issues.apache.org/jira/browse/LUCENE-1808
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Query/Scoring
> Affects Versions: 2.9
> Reporter: Tim Smith
>
> Now that the QueryWeight class has been removed, the public QueryWeight
> createQueryWeight() method on Query was also removed
> i have cases where i want to create a weight for a sub query (outside of the
> org.apache.lucene.search package) and i don't want the weight normalized
> (think BooleanQuery outside of the o.a.l.search package)
> in order to do this, i have to create a static Utils class inside
> o.a.l.search, pass in the Query and searcher, and have the static method call
> the protected createWeight method
> this should not be necessary
> This could be fixed in one of 2 ways:
> 1. make createWeight() public on Query (breaks back compat)
> 2. add the following method:
> {code}
> public Weight createQueryWeight(Searcher searcher) throws IOException {
> return createWeight(searcher);
> }
> {code}
> createWeight(Searcher) should then be deprectated in favor of the publicly
> accessible method
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
