[
https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743776#action_12743776
]
Yonik Seeley commented on LUCENE-1794:
--------------------------------------
In general, we should strive to treat our base abstract classes like
interfaces, with the ability to provide default implementations to avoid back
compatibility breaks (while avoiding adding members or non-overrideable
methods). One could make the case that the ClosableThreadLocal should not be
in Analyzer either, but it's been there long enough now, it would break back
compat to move it.
bq. What I thought was that maybe someone would want to make use of Streams w/o
extending Analyzer.
They still can - ReusableAnalyzer.Streams.
bq. But keeping it in Analyzer will allow us in the future to constrain
prevTokenStream to be of that type and not a generic Object.
Doesn't seem like we should force all tokenstreams to be reusable, or constrain
the exact form of how a reusable token stream is obtained.
> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>
> Key: LUCENE-1794
> URL: https://issues.apache.org/jira/browse/LUCENE-1794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1794-reusing-analyzer.patch, LUCENE-1794.patch,
> LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch,
> LUCENE-1794.patch
>
>
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed,
> I think we should do this to mitigate any performance costs. hey, overall it
> might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is
> easy money in my opinion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
