[
https://issues.apache.org/jira/browse/LUCENE-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743788#action_12743788
]
Robert Muir commented on LUCENE-1794:
-------------------------------------
{quote}
Robert, if possible, I'd like to get this one in as part of this issue. The
reason is that you already modified all Analyzers to impl reusableTokenStream.
I'm afraid that if we'll do it in another issue, some Analyzers will be skipped
over. If you want, I can apply this to your patch and post pack an updated one
tomorrow.
{quote}
Shai, this is a valid concern. But also lets not forget analyzers that already
implement reusableTS that are not a part of this patch (yet should be changed
to extend ReusingAnalyzer)... examples include collation/* analyzers/fa, etc.
But even before this I think we should make sure everyone is happy with
ReusingAnalyzer itself... this is the only reason I think it might merit
another issue... this patch is already a little unwieldy because I crept the
scope to include reset(Reader) and reset() methods for tokenstreams that keep
state...
> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>
> Key: LUCENE-1794
> URL: https://issues.apache.org/jira/browse/LUCENE-1794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1794-reusing-analyzer.patch, LUCENE-1794.patch,
> LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch,
> LUCENE-1794.patch
>
>
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed,
> I think we should do this to mitigate any performance costs. hey, overall it
> might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is
> easy money in my opinion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
