[
https://issues.apache.org/jira/browse/LUCENE-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1946:
----------------------------------
Attachment: LUCENE-1946.patch
Here the patch with all contrib's fixed:
- PrecedenceQueryParser was missing new TokenStream API, I fixed it somehow
with States and restoreState. I also added a javacc-target, which was missing
- InstantiatedIndexWriter was also changed to use the new TokenStream API. The
fix is very hackish, but works for the beginning. The class uses lots of
Lists/Sets with cloned Token instances inside, so I simple used an
AttributeImpl iterator and used copyTo(token). This works most cases (other
cases are ignored by a empty Exception catch block). But this should really be
fixed or the whole class removed (as suggested)
There is one question: I removed IsoLatin1Filter. Thismay be a backwards break,
so that old indexes using this filter in the analyzer need to be reindexed. But
for most cases the AccentFilter would also work, but some hits may be missing
when you query such an index. What should we do. Leave the deprecated analyzer
in and remove it with 4.0 when all old indexes cannot be read anymore?
> Remove deprecated TokenStream API
> ---------------------------------
>
> Key: LUCENE-1946
> URL: https://issues.apache.org/jira/browse/LUCENE-1946
> Project: Lucene - Java
> Issue Type: Task
> Components: Analysis, contrib/analyzers
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1946.patch, LUCENE-1946.patch, LUCENE-1946.patch
>
>
> I looked into clover analysis: It seems to be no longer used since I removed
> the tests yesterday - I am happy!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
