[ 
https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777118#action_12777118
 ] 

Tim Smith commented on LUCENE-1909:
-----------------------------------

Only thing i would want the constant for is to known what the default divisor 
is. The default just happens to be 1 (no divisor/off).

However (while unlikely) a new version of lucene could default to using a real 
divisor (maybe once everyone is on solid state disks, a higher divisor will 
result in the same speed of access, with less memory use), at which point, if i 
upgrade to a new version of lucene, i want to inherit that changed setting (as 
the default was selected by people that probably know better than me what will 
better server the general use of lucene in terms of memory and performance)

right now, if i want to inherit the default i would have to do a conditional 
IndexReader.open() and store my setting as a pair (enabled/disabled, divisor), 
which could be encoded in an Integer object (null = disabled/use lucene default)

if the constant is made public, its easier for me to inherit that default 
setting.
of course at the end of the day, either approach will only be about 5 lines of 
code difference, so again, i don't really care too much about the outcome of 
this

bq. By the way, if you use a final constant, without recompiling it would never 
change,...

I never drop a new lucene in without recompiling (so that doesn't cause any 
difference for me)

> Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public
> ---------------------------------------------------
>
>                 Key: LUCENE-1909
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1909
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Uwe Schindler
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE_1909.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to