[ 
https://issues.apache.org/jira/browse/LUCENE-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777136#action_12777136
 ] 

Tim Smith commented on LUCENE-1909:
-----------------------------------

bq. If you want to inherit the setting, use the correct constructor 

agreed, just a tiny bit of more complexity on my side for that (but its so 
insignificant that it doesn't really matter, and is really not even worth 
arguing over)

if the constant was public, i'd use it, if not, no worries (for me at least)

bq. By the default the feature is off. You can't inherit anything about it.

ideally, i want to inherit that the feature is off by default, then allow 
config to turn it on (by providing a value greater than one for this setting, 
or just 1 to allow config to explicitly disable)
using the constructor with no divisor does this (i just need to call the 
constructor conditionally depending on if the setting was explicitly 
configured), thats easy and is no problem to do at all (just a couple of extra 
lines of code in my app layer)



> Make IndexReader.DEFAULT_TERMS_INDEX_DIVISOR public
> ---------------------------------------------------
>
>                 Key: LUCENE-1909
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1909
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Uwe Schindler
>            Priority: Trivial
>             Fix For: 3.0
>
>         Attachments: LUCENE_1909.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to