[
https://issues.apache.org/jira/browse/LUCENE-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777686#action_12777686
]
Uwe Schindler edited comment on LUCENE-2064 at 11/13/09 10:42 PM:
------------------------------------------------------------------
This is cool.
Highlighter & MTQ is broken in 2.9.1. This patch looks completely broken, but
it isn't - and my mind was also broken when I first saw the patch - because of
that. This patch is cooler than all heavy commiting during ApacheCon.
+1 for 3.0 with this patch.That was what I wanted to say with my complete
nonsense comment.
was (Author: thetaphi):
This is cool.
Highlighter & MTQ is broken in 2.9.1. This patch looks completely broken - and
my mind was also broken when I first saw the patch - because of that. This
patch is cooler than all heavy commiting during ApacheCon.
+1 for 3.0 with this patch.That was what I wanted to say with my complete
nonsense comment.
> Highlighter should support all MultiFieldQuery subclasses without casts
> -----------------------------------------------------------------------
>
> Key: LUCENE-2064
> URL: https://issues.apache.org/jira/browse/LUCENE-2064
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Affects Versions: 2.9.1
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.0
>
> Attachments: LUCENE-2064.txt
>
>
> In order to support MultiTermQuery subclasses the Highlighter component
> applies instanceof checks for concrete classes from the lucene core. This
> prevents classes like RegexQuery in contrib from being supported. Introducing
> dependencies on other contribs is not feasible just for being supported by
> the highlighter.
> While the instanceof checks and subsequent casts might hopefully go somehow
> away in the future but for supporting more multterm queries I have a
> alternative approach using a fake IndexReader that uses a RewriteMethod to
> force the MTQ to pass the field name to the given reader without doing any
> real work. It is easier to explain once you see the patch - I will upload
> shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
