[
https://issues.apache.org/jira/browse/LUCENE-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777762#action_12777762
]
Mark Miller commented on LUCENE-2064:
-------------------------------------
I still think getFields on multitermquery is a better option than a Fieldable
interface. But if we would drop back to this method anyway, I see no reason to
anything with field and multitermquery at all really - unless another use case
prompts it.
> Highlighter should support all MultiTermQuery subclasses without casts
> ----------------------------------------------------------------------
>
> Key: LUCENE-2064
> URL: https://issues.apache.org/jira/browse/LUCENE-2064
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/highlighter
> Affects Versions: 2.9.1
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 3.0
>
> Attachments: LUCENE-2064.txt
>
>
> In order to support MultiTermQuery subclasses the Highlighter component
> applies instanceof checks for concrete classes from the lucene core. This
> prevents classes like RegexQuery in contrib from being supported. Introducing
> dependencies on other contribs is not feasible just for being supported by
> the highlighter.
> While the instanceof checks and subsequent casts might hopefully go somehow
> away in the future but for supporting more multterm queries I have a
> alternative approach using a fake IndexReader that uses a RewriteMethod to
> force the MTQ to pass the field name to the given reader without doing any
> real work. It is easier to explain once you see the patch - I will upload
> shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
