[ https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780623#action_12780623 ]
Robert Muir edited comment on LUCENE-1606 at 11/20/09 4:27 PM: --------------------------------------------------------------- attached is an alternate patch with no library dependency (LUCENE-1606_nodep.patch) instead it imports 'pared-down' automaton source code (compiles to 48KB jar) it is still setup in contrib regex because... Mark: some practical questions, I'd like to create a patch that integrates it nicely into core, just so we can see what it would look like. Thoughts on class names and pkg names? * I assume we should nuke the old WildcardQuery, rename AutomatonWildcardQuery to WildcardQuery? * but then what should AutomatonRegexQuery be called, we already have RegexQuery :) Thoughts on the automaton src code? Should I reformat to our style... (I did not do this). should we rename the pkg? sorry the patch is monster, if it makes it any easier i could split the automaton library itself away from the lucene integration (queries, etc)? also, i did not remove any tests, for example, TestWildcardQuery already exists, so the test here is just duplication, i just might add a test or 2 to the existing TestWildcardQuery was (Author: rcmuir): attached is an alternate patch with no library dependency (LUCENE-1606_nodep.patch) instead it imports 'pared-down' automaton source code (compiles to 48KB jar) it is still setup in contrib regex because... Mark: some practical questions, I'd like to create a patch that integrates it nicely into core, just so we can see what it would look like. Thoughts on class names and pkg names? * I assume we should nuke the old WildcardQuery, rename AutomatonWildcardQuery to WildcardQuery? * but then what should AutomatonRegexQuery be called, we already have RegexQuery :) Thoughts on the automaton src code? Should I reformat to our style... (I did not do this). should we rename the pkg? sorry the patch is monster, if it makes it any easier i could split the automaton library itself away from the lucene integration (queries, etc)? > Automaton Query/Filter (scalable regex) > --------------------------------------- > > Key: LUCENE-1606 > URL: https://issues.apache.org/jira/browse/LUCENE-1606 > Project: Lucene - Java > Issue Type: New Feature > Components: contrib/* > Reporter: Robert Muir > Assignee: Robert Muir > Priority: Minor > Fix For: 3.1 > > Attachments: automaton.patch, automatonMultiQuery.patch, > automatonmultiqueryfuzzy.patch, automatonMultiQuerySmart.patch, > automatonWithWildCard.patch, automatonWithWildCard2.patch, LUCENE-1606.patch, > LUCENE-1606.patch, LUCENE-1606_nodep.patch > > > Attached is a patch for an AutomatonQuery/Filter (name can change if its not > suitable). > Whereas the out-of-box contrib RegexQuery is nice, I have some very large > indexes (100M+ unique tokens) where queries are quite slow, 2 minutes, etc. > Additionally all of the existing RegexQuery implementations in Lucene are > really slow if there is no constant prefix. This implementation does not > depend upon constant prefix, and runs the same query in 640ms. > Some use cases I envision: > 1. lexicography/etc on large text corpora > 2. looking for things such as urls where the prefix is not constant (http:// > or ftp://) > The Filter uses the BRICS package (http://www.brics.dk/automaton/) to convert > regular expressions into a DFA. Then, the filter "enumerates" terms in a > special way, by using the underlying state machine. Here is my short > description from the comments: > The algorithm here is pretty basic. Enumerate terms but instead of a > binary accept/reject do: > > 1. Look at the portion that is OK (did not enter a reject state in the > DFA) > 2. Generate the next possible String and seek to that. > the Query simply wraps the filter with ConstantScoreQuery. > I did not include the automaton.jar inside the patch but it can be downloaded > from http://www.brics.dk/automaton/ and is BSD-licensed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org