[ 
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784407#action_12784407
 ] 

Robert Muir commented on LUCENE-2102:
-------------------------------------

Hi Ahmet, this patch is looking very nice, thank you!

I have some minor suggestions:
* can we use hex notation (maybe also constants too) for the special case?
* you can use assertTokenStreamContents here (it is in the base test case) to 
simplify your test, it works like assertAnalyzesTo but on tokenstream

I will let others comment on where this belongs (maybe contrib?)
Wherever it is, I would like to use it in snowball contrib also.


> LowerCaseFilter for Turkish language
> ------------------------------------
>
>                 Key: LUCENE-2102
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2102
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>    Affects Versions: 3.0
>            Reporter: Ahmet Arslan
>            Priority: Minor
>         Attachments: LUCENE-2102.patch
>
>
> java.lang.Character.toLowerCase() converts 'I' to 'i' however in Turkish 
> alphabet lowercase of 'I' is not 'i'. It is LATIN SMALL LETTER DOTLESS I.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to