[ 
https://issues.apache.org/jira/browse/LUCENE-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785271#action_12785271
 ] 

Uwe Schindler commented on LUCENE-2091:
---------------------------------------

I was wondering about the separate BooleanQuery, too as it is almost simply a 
copy (of an old version of it). The question is more, why do we need the BM25 
calsses at ally, why should it be not possible to use normal term queries and 
other query types together with BM25 by just changing some scoring defaults? So 
replace Similarity and maybe have a switch inside the scorers. So TermQuery 
could be switched to BM25 mode and then using another Scorer or something like 
that.

That was just my first impression, these additional classes do not look like a 
good public API to me. Query classes should be abstract wrappers for wights and 
scoreres. The internal impl like BM25 or conventional should be hidden from the 
user (and maybe properties e.g. on the IndexSearcher to use BM25 scoring). This 
way, it could also be used for other query types (not only TermQ/BQ), but eg. 
for function queries (to further change the score) or FuzzyQuery and what else.

If what I said is complete nonsense, don't hurt me, I do not know much about 
BM25, but for me it is an implementation detail and not part of a public API.

> Add BM25 Scoring to Lucene
> --------------------------
>
>                 Key: LUCENE-2091
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2091
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: contrib/*
>            Reporter: Yuval Feinstein
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: LUCENE-2091.patch, persianlucene.jpg
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> http://nlp.uned.es/~jperezi/Lucene-BM25/ describes an implementation of 
> Okapi-BM25 scoring in the Lucene framework,
> as an alternative to the standard Lucene scoring (which is a version of mixed 
> boolean/TFIDF).
> I have refactored this a bit, added unit tests and improved the runtime 
> somewhat.
> I would like to contribute the code to Lucene under contrib. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to