[
https://issues.apache.org/jira/browse/LUCENE-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-2135:
---------------------------------------
Attachment: LUCENE-2135.patch
I would love to see a bigger solution here, but in the interim, I
think we should fix the current FieldCache (patch attached).
The patch adds FieldCache.purge to the interface. This is technically
a break in back-compat, to any external impls of FieldCache, but
that's such an insanely expert & difficult thing that I think it's
fine to make an exception.
A few tests (incl back-compat) needed fixing, because they were
closing the reader in-between to calls to getInts and then incorrectly
asserting the int[]'s were the same.
> IndexReader.close should forcefully evict entries from FieldCache
> -----------------------------------------------------------------
>
> Key: LUCENE-2135
> URL: https://issues.apache.org/jira/browse/LUCENE-2135
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE-2135.patch
>
>
> Spinoff of java-user thread "heap memory issues when sorting by a string
> field".
> We rely on WeakHashMap to hold our FieldCache, keyed by reader. But this
> lacks immediacy on releasing the reference, after a reader is closed.
> WeakHashMap can't free the key until the reader is no longer referenced by
> the app. And, apparently, WeakHashMap has a further impl detail that requires
> invoking one of its methods for it to notice that a key has just become only
> weakly reachable.
> To fix this, I think on IR.close we should evict entries from the FieldCache,
> as long as the sub-readers are truly closed (refCount dropped to 0).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
