[ 
https://issues.apache.org/jira/browse/LUCENE-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791065#action_12791065
 ] 

Michael McCandless commented on LUCENE-2120:
--------------------------------------------

{quote}
bq. is this what the private static int MAX_READER_GENERATION = 3

No, I misunderstood you. This is just a number I think it is safe to keep for 
make sure you don't close reader while it is being searched.
{quote}

Ahh I see.... you can incRef/decRef the reader to handle that.

{quote}
bq. you resolve the deleted docs in the BG

That is not really true. It is stored in a DocIdSet, and it does the skipping 
in a special TermDocs for avoid deletes.

I am not sure I understand what you mean by "double check deletions". Warming 
is done in the background, in the foreground you do search along with ram 
indexes that hold transient indexing updates. So one guarantee is that the any 
time search is happening the disk index is warm, so you don't have to pay the 
cost related to warming.
{quote}

Sorry, maybe I'm misunderstanding what was done on the BR_DELETE_OPT branch -- 
I thought the idea was to avoid having to always double-check deletes by 
resolving them to docIDs in the BG (described at 
https://issues.apache.org/jira/browse/LUCENE-1526?focusedCommentId=12776994&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12776994).
  I'll try to diff the branch...

bq. BTW, i have merged BR_DELETE_OPT down to trunk and did a release. Feel free 
to take from trunk.

OK thanks.

> Possible file handle leak in near real-time reader
> --------------------------------------------------
>
>                 Key: LUCENE-2120
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2120
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.1
>
>
> Spinoff of LUCENE-1526: Jake/John hit file descriptor exhaustion when testing 
> NRT.
> I've tried to repro this, stress testing NRT, saturating reopens, indexing, 
> searching, but haven't found any issue.
> Let's try to get to the bottom of it, here...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to