[ 
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848565#action_12848565
 ] 

Shai Erera commented on LUCENE-2339:
------------------------------------

I personally haven't seen problem using NIO on Windows, but that's perhaps just 
because I haven't run into them yet :). I think your proposal makes sense - 
let's start w/ NIO bulk-copy and then we can disable if people complain or 
report errors.

Consistency is important, I agree. So let's keep Collection there. I just 
wanted to avoid converting arrays to a Collection, just so that they can be 
iterated on. Seems a waste to me, but not so much to argue about :).

Re (7), I hate such libraries too. But I hate more the ones that just hide 
problems away from me :). The ideal thing was if Lucene would use a logging 
mechanism (I once started it on LUCENE-1482) so that you could include the 
stacktrace print if logging is enabled. But currently the code just hides the 
problem away ... and I'd hate to debug such thing, not realizing an IO 
exception is thrown from close().

So unless LUCENE-1482 springs back to life again, what do you suggest we do? 
Suppressing the exceptions seems wrong to me.

> Allow Directory.copy() to accept a collection of file names to be copied
> ------------------------------------------------------------------------
>
>                 Key: LUCENE-2339
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2339
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>            Assignee: Michael McCandless
>         Attachments: LUCENE-2339.patch, LUCENE-2339.patch, LUCENE-2339.patch
>
>
> Par example, I want to copy files pertaining to a certain commit, and not 
> everything there is in a Directory.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to