[ https://issues.apache.org/jira/browse/LUCENE-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851008#action_12851008 ]
Michael McCandless commented on LUCENE-2354: -------------------------------------------- bq. NumericUtils still contains lots of unused String-based methods, I think we should remove them +1 Patch looks good! NumericFields are the first thing to index terms directly as byte[] (ie not first going through char[]) in flex. But the encoding is unchanged right? (Ie only using 7 bits per byte, same as trunk). And you cutover to BytesRef TermsEnum API too -- great. Presumably search perf would improve but only a tiny bit since NRQ visits so few terms? > Convert NumericUtils and NumericTokenStream to use BytesRef instead of > Strings/char[] > ------------------------------------------------------------------------------------- > > Key: LUCENE-2354 > URL: https://issues.apache.org/jira/browse/LUCENE-2354 > Project: Lucene - Java > Issue Type: Improvement > Affects Versions: Flex Branch > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: Flex Branch > > Attachments: LUCENE-2354.patch > > > After LUCENE-2302, we should use TermToBytesRefAttribute to index using > NumericTokenStream. This also should convert the whole NumericUtils to use > BytesRef when converting numerics. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org