I went through the javadoc changes and, although I'm no javadoc expert, they seem clean enough, to the point that I could follow the logic quite easily.

One high-level gripe which is pointing at a failure of the j.l.model API is the lack of a way to get to the canonical constructor directly; we have this issue both in core reflection and source reflection, and I think we should address that, as both serialization and javadoc has to DYI around that.

Maurizio

On 17/10/2019 20:45, Jonathan Gibbons wrote:
cc: javadoc-dev@openjdk.java.net

--Jon


On 10/17/2019 12:43 PM, Vicente Romero wrote:
Hi,

Please review the javadoc code for JEP 359 (Records), this webrev contains only the javadoc code as we have decided to split the new code in clusters to make the review process easier.

Thanks in advance for the feedback,
Vicente

PS, Jon is the author of this code please keep him in the loop

http://cr.openjdk.java.net/~vromero/records.review/javadoc/webrev.00/

Reply via email to