Generally, for historical reasons I accept, the jx.l.m model API has not
been very friendly with helpful utility methods, going for a more
minimalist approach, although I sense that is changing, maybe in part
because of default methods.
With respect to accessing the canonical constructor, I would like to see
jx.l.m provide utility methods either for all the derived features of a
record (canonical constructor, fields, accessors) or none, depending on
the level of convenience desired. Having a mix of some but not others
is just confusing. Access to `equals` and `hashCode` can/should be
provided by more general methods that need not be specific to records.
-- Jon
On 10/18/19 5:28 AM, Maurizio Cimadamore wrote:
I went through the javadoc changes and, although I'm no javadoc
expert, they seem clean enough, to the point that I could follow the
logic quite easily.
One high-level gripe which is pointing at a failure of the j.l.model
API is the lack of a way to get to the canonical constructor directly;
we have this issue both in core reflection and source reflection, and
I think we should address that, as both serialization and javadoc has
to DYI around that.
Maurizio
On 17/10/2019 20:45, Jonathan Gibbons wrote:
cc: javadoc-dev@openjdk.java.net
--Jon
On 10/17/2019 12:43 PM, Vicente Romero wrote:
Hi,
Please review the javadoc code for JEP 359 (Records), this webrev
contains only the javadoc code as we have decided to split the new
code in clusters to make the review process easier.
Thanks in advance for the feedback,
Vicente
PS, Jon is the author of this code please keep him in the loop
http://cr.openjdk.java.net/~vromero/records.review/javadoc/webrev.00/
