On Tue, 25 May 2021 17:32:11 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
> Although the `com.sun.tools.javadoc.**` packages were removed in JDK-8215584, > some references to them remain, mainly in the form of links in doc comments. > Some of those links refer to classes that never existed, which I reckon is > due to a typo; for example, this reference > > com.sun.tools.javadoc.ClassDocImpl#findField > > should've looked like this > > com.sun.tools.javadoc.main.ClassDocImpl#findField > > Grep showed that some tests also use `com.sun.tools.javadoc` and some other > extinct packages. However, it is unclear if those "references" should also be > removed: > > 1. > https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/test/langtools/tools/javac/NoStringToLower.java#L60-L74 > 2. > https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/test/langtools/tools/javac/T8003967/DetectMutableStaticFields.java#L73-L85 1. Removed extinct packages 2. Removed `ignore("jdk/javadoc/internal/tool/Start", "versionRB")` since `Start.versionRB` was removed in JDK-8246078 3. Returned updated deprecation info. When I fixed the location of javadoc, the NoStringToLower test found two issues it could not see before, both of which I then fixed. I also note, that this method in DetectMutableStaticFields should perhaps use `String.startsWith` instead of `String.contains` in which case `packagesToSeekFor` should be also renamed to `packagePrefixesToSeekFor`: boolean shouldAnalyzePackage(String packageName) { for (String aPackage: packagesToSeekFor) { if (packageName.contains(aPackage)) { return true; } } return false; } But if this is to be fixed, it should be done in a separate PR. ------------- PR: https://git.openjdk.java.net/jdk/pull/4192
