On Fri, 24 Sep 2021 16:43:28 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> test/langtools/tools/lib/toolbox/ToolBox.java line 270:
>>
>>> 268: public void copyDir(Path fromDir, Path toDir) {
>>> 269: try {
>>> 270: Files.createDirectories(toDir);
>>
>> Do not create this directory manually. It will be created first thing in
>> your visitor.
>> Suggestion:
>
> The suggestion is incorrect. The call is required to ensure that parent
> directories of `toDir` are created. These are __not__ created by the call
> in the visitor.
You are right. I forgot about parent directories. I saw your change in 47c5acc
that creates the parent path. This is good.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5644
