On Thu, 23 Sep 2021 01:44:27 GMT, Jonathan Gibbons <[email protected]> wrote:
> Please review a moderately simple update to convert JavadocTester to just use > NIO, instead of a mix of File and NIO. > > The original code used java.io.File. At some point (JDK 9-ish) new code was > added that used NIO, resulting in a mix. This change converts the old code to > use NIO as well. > > This is mostly internal, with two changes that affect tests. > > 1. The `protected` field `outputDir` is changed from a `File` to a `Path`. > Some tests use `outputDir` directly, typically to convert it to a `Path`. > 2. The `copyDir` method had a strange spec. Partly, it used "target" to > describe the directory being copied, but worse, it copied the entire source > directory INTO the destination directory, as compared to copying the > contents. The method was just used in a single test, so I've changed the > spec of the method and the use in the test. This cleaned up a "TODO" as > well, to use `Files.walkFileTree` for the copy. This pull request has now been integrated. Changeset: 5b0c9ccc Author: Jonathan Gibbons <[email protected]> URL: https://git.openjdk.java.net/jdk/commit/5b0c9ccc495b6bf8061c161d48f73238c7167bc0 Stats: 207 lines in 8 files changed: 67 ins; 55 del; 85 mod 8274172: Convert JavadocTester to use NIO Reviewed-by: prappo ------------- PR: https://git.openjdk.java.net/jdk/pull/5644
