On Wed, 3 Nov 2021 15:08:04 GMT, Pavel Rappo <[email protected]> wrote:
> Here's what I see after your two force pushes. The discussions we started
> have become outdated and got severed, meaning that we cannot continue them
> much less mark them "Unresolved". Lines in the cumulative diff ("Files
> changed") that I could've sworn were there, have disappeared such that we
> could no longer discuss them. For example, I wanted to add a further inline
> comment on an optional newline in `<pre\>` but I cannot do that because
> neither the line is present nor the discussion can be continued.
I have to say that the discussions could not be continued not because of the
force push, but because I had had a pending (incomplete, ongoing, etc.) review
started in my IDE. Apologies for jumping to conclusions. That said, it would be
good to avoid force pushes where possible for other reasons I stated.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6165
