On Wed, 3 Nov 2021 18:40:21 GMT, Pavel Rappo <[email protected]> wrote:
> Here's what I see after your two force pushes. The discussions we started
> have become outdated and got severed, meaning that we cannot continue them
> much less mark them "Unresolved". Lines in the cumulative diff ("Files
> changed") that I could've sworn were there, have disappeared such that we
> could no longer discuss them. For example, I wanted to add a further inline
> comment on an optional newline in `<pre\>` but I cannot do that because
> neither the line is present nor the discussion can be continued.
Thanks for the review, Pavel!
I think you misunderstand the scope of the force-push. I didn't force-push any
commit that had already been reviewed, it was just the trivial last change to
remove most of the recognized file extensions. I initially removed the file
extensions in one commit, and then in an extra commit simplified the switch
expression with just two remaining cases to an if-statement. I didn't like to
have two commits for such a simple change, so I immediately replaced them with
a unified commit. I know that's not ideal. I'll try to leave my "stupid"
commits out in the open in the future.
Yes, some discussion points have gone in the cumulative diff, but that's not
because of the force-push. For instance, the newline change has moved because
of the merge of the master branch (manually merging in the copy-to-clipboard
feature). And of course the file extension discussion has gone in the
cumulative diff because I decided it was just not worth the rat-tail of
complexities (documentation, politics etc.)
As you'll see the individual commits are still there and also contain all the
comments:
https://github.com/openjdk/jdk/pull/6165/commits/6bca94ba7f54c50a132d5f28476fe56b8eff06c2
-------------
PR: https://git.openjdk.java.net/jdk/pull/6165
