On Thu, 18 Nov 2021 17:24:17 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test one more corner case example
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SnippetTaglet.java
> line 202:
>
>> 200: fileObject =
>> fileManager.getFileForInput(Location.SNIPPET_PATH, "", v);
>> 201: }
>> 202: } catch (IOException | IllegalArgumentException e) { //
>> TODO: test this when JDK-8276892 is integrated
>
> FYI: The documented conditions of `IllegalArgumentException` do not arise in
> this context, although it's not wrong to catch the exception.
You are much more knowledgeable in FileManager than I am. My thinking was that
while it's probably not an issue with the default file manager, I couldn't
guarantee that IllegalArgumentException is not thrown if this code runs with a
custom file manager.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6359
