On Fri, 19 Nov 2021 16:18:25 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>>
>> - Hoist the tb (toolbox) field to SnippetTester
>> - Use use default ctors instead of private no-arg ctors for test classes
>> - Re-implement SnippetTester.checkOutputEither on top of
>> JavadocTester.OutputChecker.checkAnyOf
>> - Follow convention for jtreg comment
>> - Improve method names with underscores
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Attribute.java
> line 61:
>
>> 59: * deletion without notice.</b>
>> 60: */
>> 61: public abstract class Attribute {
>
> General question: the commit message is:
>
>> So we can finally use sealed classes where they were originally envisioned.
>
> But, the code edits seem to be backing away from using sealed classes and
> interfaces. What happened?
This is embarrassing. The commit clearly contradicts its message, and I don't
immediately understand why. I'll try to figure it out before integrating.
Thanks for noticing!
-------------
PR: https://git.openjdk.java.net/jdk/pull/6359
