On Tue, 31 May 2022 16:02:40 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> Looks good to me. I'm not sure the `requireNonNull` method carries its own > weight given that one `getSnippetById` method could by implemented by calling > the other, but that's a minor stylistic concern. Note that the `requireNonNull` method is a local method to ensure the intended specific exception is thrown. It is not plain old `Objects.requireNonNull` that throws plain old NPE. ------------- PR: https://git.openjdk.java.net/jdk/pull/8892
