On Tue, 31 May 2022 23:43:34 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Please review a simple change for `SnippetUtils` to throw a checked >> exception if a snippet cannot be found. > > Jonathan Gibbons has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - address review feedback > - Merge remote-tracking branch 'upstream/master' into 8287337.snippetutils > - JDK-8287337: SnippetUtils should throw exceptions if snippets not found The new version looks good to me. I hadn't even thought about the case of the missing comment, I like that it's handled explicitly now. ------------- Marked as reviewed by hannesw (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8892
