On Mon, 24 Oct 2022 21:11:06 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix: test failed due to filesystem handling issues >> >> Filed 8295543 to track that filesystem issue and fixed the test to make >> sure the package cannot be confused with the type parameter, whose >> name is not pertinent to the test anyway. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java > line 365: > >> 363: var subtypeTestInapplicable = t.getKind() == TypeKind.EXECUTABLE >> 364: || t.getKind() == TypeKind.PACKAGE >> 365: || t.getKind() == TypeKind.MODULE; > > Just asking ... would this be more concise as an enhanced switch expression? A `switch` expression will likely look uglier than you might think. Care to suggest such an expression? Performance implications aside, perhaps an `EnumSet` could be more readable. ------------- PR: https://git.openjdk.org/jdk/pull/10746
