On Mon, 24 Oct 2022 20:28:38 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix: test failed due to filesystem handling issues >> >> Filed 8295543 to track that filesystem issue and fixed the test to make >> sure the package cannot be confused with the type parameter, whose >> name is not pertinent to the test anyway. > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/InheritDocTaglet.java > line 115: > >> 113: + utils.flatSignature(method, >> writer.getCurrentPageElement()); >> 114: messages.warning(method, "doclet.noInheritedDoc", >> signature); >> 115: } > > Lines 99-115: would it help to refactor this to use an `instanceof` pattern? Please suggest how you'd do it. When I last tried it, that adjacent null check was in the way. ------------- PR: https://git.openjdk.org/jdk/pull/10746
