On Tue, 31 Jan 2023 14:55:34 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix broken tests
>
> test/langtools/tools/javac/doctree/DocCommentTester.java line 922:
>
>> 920: String s2 = s.trim().replaceFirst("\\.\\s*\\n *@", ".\n@");
>> 921: StringBuilder sb = new StringBuilder();
>> 922: Pattern p = Pattern.compile("(?i)\\{@([a-z][a-z0-9.:-]*)(
>> )?");
>
> Why is this change necessary? I see it is intended to impact the unknown
> inline tag in `TagTest.java`, but couldn't the test be written without this
> change?
Previously, the only tags in which `newline at` was supported were `{@code}`
`{@literal}` and `{@snippet}` ... and this tag predated `{@snippet}` which is
the main reason it's not included here.
Now `newline at` is supported in all inline tags, so the scope of this check is
broadened accordingly.
-------------
PR: https://git.openjdk.org/jdk/pull/12264
