On Tue, 31 Jan 2023 15:28:42 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
> There's something wrong with this, several `javac/doctree` tests are failing. Yes, now fixed. The breakage was obviously due to the change you mentioned above (for `code|literal` tags). The fix in most cases (one exception) was to make the `PrettyChecker` more robust. The one difficult case was a syntactically invalid tag (which was in most ways a reasonable test case) but which led to false positive matches in the `normalize` code. For that case, I created a "backdoor" to pass a boolean flag to the `normalize` code by means of an annotation on the test case. Note that because the test case is only _parsed_ and never _analyzed_, the annotation does not need a declaration, it's enough to have an annotation show up in the AST, where it can be accessed by the `PrettyChecker` code. ------------- PR: https://git.openjdk.org/jdk/pull/12264
