On Fri, 9 Jun 2023 05:47:50 GMT, KIRIYAMA Takuya <d...@openjdk.org> wrote:
>> I modified the location from which javadoc copies some legal files to the
>> generated documentation. If --legal-notices　option is set to default or
>> nothing is specified,, GPLv2 Legal Documents are copied from
>> legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and
>> ASSEMBLY_EXCEPTION.
>>
>> Would you please review this fix?
>
> KIRIYAMA Takuya has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains four additional
> commits since the last revision:
>
> - Merge remote-tracking branch 'origin' into 8306980
> - 8306980: Generated docs should contain correct GPLv2 Legal Documents
> - 8306980: Generated docs should contain correct GPLv2 Legal Documents
> - 8306980: Generated docs should contain correct GPLv2 Legal Documents
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java
line 383:
> 381: entry = descriptive_link;
> 382: }
> 383: } catch(InvalidPathException e) {}
nit
Suggestion:
} catch (InvalidPathException e) {}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13686#discussion_r1228411093
