On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya <d...@openjdk.org> wrote:
>> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices　option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/ directory, such as LICENSE, ADDITIONAL_LICENSE_INFO and >> ASSEMBLY_EXCEPTION. >> >> Would you please review this fix? > > KIRIYAMA Takuya has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merge remote-tracking branch 'origin' into 8306980 > - 8306980: Generated docs should contain correct GPLv2 Legal Documents > - Merge remote-tracking branch 'origin' into 8306980 > - 8306980: Generated docs should contain correct GPLv2 Legal Documents > - 8306980: Generated docs should contain correct GPLv2 Legal Documents > - 8306980: Generated docs should contain correct GPLv2 Legal Documents Thank you Mandy. If it's OK then I'll go ahead and file an enhancement for jlink tool and propose a PR with these suggested changes. This current issue can then be used to do the build side changes to mark `jdk.javadoc` module as not needing deduplication. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13686#issuecomment-1748111199
