Please review a medium size update that is the last in the series of recent 
updates to refactor and simplify  builders and writers.

Having cleared away some of the earlier obfuscation, it becomes clear that all 
subtypes of `HtmlDocletWriter` generate pages for the overall documentation, 
and so a new abstract method `buildPage` is introduced to make that more 
obvious. This resulted in renaming some existing `build` methods and/or 
removing some static `generate` methods, though some of the more complex ones 
still remain.

In addition, all writers are now generally created by the `WriterFactory` 
class, providing an extension point should it ever be needed to subtype these 
classes. The methods on `WriterFactory` return the appropriate supertype 
(`HtmlDocletWriter` or `AbstractMemberWriter`) thus enforcing the use of the 
standard abstract methods that are now available.

There is also some cleanup to some of the member writers, including introducing 
more abstract methods to define common behavior, simplifying some method 
signatures, removing unused code, and providing documentation comments.

-------------

Commit messages:
 - Address review feedback
 - JDK-8313349: Introduce `abstract void HtmlDocletWriter.buildPage()`

Changes: https://git.openjdk.org/jdk/pull/15114/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15114&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8313349
  Stats: 1249 lines in 46 files changed: 420 ins; 499 del; 330 mod
  Patch: https://git.openjdk.org/jdk/pull/15114.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15114/head:pull/15114

PR: https://git.openjdk.org/jdk/pull/15114

Reply via email to