On Tue, 1 Aug 2023 23:52:15 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
> Please review a medium size update that is the last in the series of recent > updates to refactor and simplify builders and writers. > > Having cleared away some of the earlier obfuscation, it becomes clear that > all subtypes of `HtmlDocletWriter` generate pages for the overall > documentation, and so a new abstract method `buildPage` is introduced to make > that more obvious. This resulted in renaming some existing `build` methods > and/or removing some static `generate` methods, though some of the more > complex ones still remain. > > In addition, all writers are now generally created by the `WriterFactory` > class, providing an extension point should it ever be needed to subtype these > classes. The methods on `WriterFactory` return the appropriate supertype > (`HtmlDocletWriter` or `AbstractMemberWriter`) thus enforcing the use of the > standard abstract methods that are now available. > > There is also some cleanup to some of the member writers, including > introducing more abstract methods to define common behavior, simplifying some > method signatures, removing unused code, and providing documentation comments. Looks good to me. ------------- Marked as reviewed by prappo (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15114#pullrequestreview-1559865214
