> Please review a fix for multiple issues that caused a horizontal scrollbar to 
> appear on the list of search results in JavaDoc-generated documentation even 
> when not required by the list content. The problems are described in more 
> detail in the JBS issue, but to summarize:
> 
>  - Our category headers contained horizontal padding which was added to the 
> width of 100%. This is solved by adding `box-sizing: border-box` where 
> necessary.
>  - The selected item is shown with a negative margin and positive border to 
> work around a browser bug, which also caused horizontal overflow. This is 
> solved by only applying the margin and border to the vertical axis.
> 
> For the second fix it was also necessary to change the order in which 
> stylesheets are loaded in HTML files in order to be able to override 
> declarations in the JQuery-UI stylesheet.
> 
> I also added a little bit of vertical padding to result list items as the 
> list looked very crammed to me. Generated documentation (top-level files 
> only) can be viewed at the URL below. Search results should not display a 
> horizontal scrollbar unless required by the contents of the list.
> 
> https://cr.openjdk.org/~hannesw/8275889/api.00/

Hannes Wallnöfer has updated the pull request incrementally with one additional 
commit since the last revision:

  Add newly overridden jquery-ui classes to stylesheet checker

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16731/files
  - new: https://git.openjdk.org/jdk/pull/16731/files/bb620519..bfe48129

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16731&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16731&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/16731.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16731/head:pull/16731

PR: https://git.openjdk.org/jdk/pull/16731

Reply via email to