On Mon, 20 Nov 2023 10:25:55 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review a fix for multiple issues that caused a horizontal scrollbar >> to appear on the list of search results in JavaDoc-generated documentation >> even when not required by the list content. The problems are described in >> more detail in the JBS issue, but to summarize: >> >> - Our category headers contained horizontal padding which was added to the >> width of 100%. This is solved by adding `box-sizing: border-box` where >> necessary. >> - The selected item is shown with a negative margin and positive border to >> work around a browser bug, which also caused horizontal overflow. This is >> solved by only applying the margin and border to the vertical axis. >> >> For the second fix it was also necessary to change the order in which >> stylesheets are loaded in HTML files in order to be able to override >> declarations in the JQuery-UI stylesheet. >> >> I also added a little bit of vertical padding to result list items as the >> list looked very crammed to me. Generated documentation (top-level files >> only) can be viewed at the URL below. Search results should not display a >> horizontal scrollbar unless required by the contents of the list. >> >> https://cr.openjdk.org/~hannesw/8275889/api.00/ > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Add newly overridden jquery-ui classes to stylesheet checker Ugh for the underlying problem. ------------- Marked as reviewed by jjg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16731#pullrequestreview-1740401974
