On Tue, 10 Dec 2024 00:40:23 GMT, Henry Jen <henry...@openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with four additional 
>> commits since the last revision:
>> 
>>  - implement Severin's review
>>    
>>    Co-authored-by: Severin Gehwolf <jerb...@gmail.com>
>>  - implement Jan's review
>>  - implement Henry's review
>>  - implement Weijun's review
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties
>  line 43:
> 
>> 41: resource.installdirnotemptydlg-wix-file=安装目录对话框 WiX 项目文件非空
>> 42: resource.launcher-as-service-wix-file=服务安装程序 WiX 项目文件
>> 43: resource.wix-src-conv=将 WiX 源从 WiX v3 格式转换为 WiX v4 格式的 XSLT 样式表
> 
> Nitpick: The sources here means source code, I would think 源码 is more 
> appropriate.
> 将 WiX 源从 WiX v3 格式转换为 WiX v4 格式的 XSLT 样式表
> 将 WiX 源码从 WiX v3 格式转换为 WiX v4 格式的 XSLT 样式表

This and your other comments fixed in 
https://github.com/openjdk/jdk/pull/22588/commits/2d9653259d828d5899a1ffeb6af1c05fb5f4d10f.
 Regarding `"每个 <package> 是\n限定的程序包名称."`, yes we should follow the args format, 
that is, do not translate the contents within < >. I'll speak to the 
translation team about your comments to get them fixed on their side.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22588#discussion_r1878712996

Reply via email to