On Thu, 14 Nov 2024 08:01:12 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - add file with all vetted links >> - improve some parts based on review comments >> - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit >> - Merge remote-tracking branch 'upstream/master' into new-docs-tests-suit >> - Convert parts of doccheck into tests > > test/docs/jdk/javadoc/doccheck/doccheckutils/checkers/BadCharacterChecker.java > line 122: > >> 120: return Charset.forName(m2.group(1)); >> 121: } >> 122: return html5 ? StandardCharsets.UTF_8 : >> StandardCharsets.ISO_8859_1; > > What is the basis for assuming ISO-8859-1 for non-HTML5 files? I assumed text would be written in latin characters, but I guess this can be removed and we can simply use UTF8? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21879#discussion_r1884202549
