On Fri, 13 Dec 2024 17:12:56 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> I assumed text would be written in latin characters, but I guess this can be >> removed and we can simply use UTF8? > > Unicode has some characters such as bidi characters which I don't want to > allow but this test should only check for bistrot and character encoding, so > UTF_8 could work as a default. Note that JDK source code is inconsistent. The makefile commands for `javac` specify just ASCII (since forever) but the `javadoc` commands allow ISO-8859-1, which was popular before the widespread acceptance of UTF-8. Ideally, all should be self-consistent -- JDK policy, `javac` commands, `javadoc` commands, DocCheck, etc. Note that resource files might use different encodings to `*.java` source files. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21879#discussion_r1885390363