On Mon, 27 Apr 2026 15:05:34 GMT, Hannes Wallnöfer <[email protected]> wrote:
> Please review a simple change to add tooltips (title attributes) to the links > in the breadcrumb sub-navigation bar, as well as to the search and filter > input fields. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java line 429: > 427: private String getTitle(Element elem) { > 428: return switch (elem) { > 429: case ModuleElement moduleElement -> contents.moduleLabel + " > " + moduleElement.getQualifiedName(); I think we should allow localization to customize this order - this is a "right branching" form that doesn't work with languages like Japanese, see https://en.wikipedia.org/wiki/Branching_(linguistics) src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TableOfContents.java line 106: > 104: var header = HtmlTree.DIV(HtmlStyles.tocHeader, > writer.contents.contentsHeading); > 105: if (hasFilterInput) { > 106: var filterLabel = > writer.resources.getText("doclet.filter_label"); Suggestion: var filterLabel = writer.resources.getText("doclet.filter_label"); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30947#discussion_r3148690771 PR Review Comment: https://git.openjdk.org/jdk/pull/30947#discussion_r3148668076
