On Mon, 27 Apr 2026 16:12:51 GMT, Chen Liang <[email protected]> wrote:
>> Please review a simple change to add tooltips (title attributes) to the >> links in the breadcrumb sub-navigation bar, as well as to the search and >> filter input fields. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java > line 429: > >> 427: private String getTitle(Element elem) { >> 428: return switch (elem) { >> 429: case ModuleElement moduleElement -> contents.moduleLabel + >> " " + moduleElement.getQualifiedName(); > > I think we should allow localization to customize this order - this is a > "right branching" form that doesn't work with languages like Japanese, see > https://en.wikipedia.org/wiki/Branching_(linguistics) I suspected this as well, but it turns out we're using this hardcoded order in all module, package and type page headers: - https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriter.java#L270-L272 - https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriter.java#L207-L210 - https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriter.java#L131 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30947#discussion_r3148948414
