I agree with Luc's suggestions, and would add that you should probably look at using Crucible for managing your code reviews. It makes it easier to collect feedback, especially in cases where everyone is working on separate projects. I worked at a company once, where everyone worked on different applications, or releases. As a result, no one wanted to do a code review since it involved downloading another branch, or setting up a separate project, just to support the code review. By switching to Crucible, you simply send people a URL for the code you want them to review. The comments are captured online.
http://www.atlassian.com/software/crucible/ Hope this helps, Mark On Thu, Feb 12, 2009 at 6:36 AM, Luc Trudeau <[email protected]> wrote: > IMHO > > You should not waste time reviewing things that tools can find for you. > Before setting up a code review process, I would start with : > > - Define a coding format and use Checkstyle to enforce it (IDE can help > you out with this) > - Enforce a 0 compiler warning policy > - Use PMD and Findbugs to look at the code. You will also need to > define what FindBugs/PMD issues you're willing to live with. > > After you set these foundations, I would use crap4j to list the crap in the > code base. And I review that starting with the crappiest. > > > In order to keep this answer short, I'm not going to address TDD. Which can > also be good for reviewing good and share knowledge. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "The Java Posse" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/javaposse?hl=en -~----------~----~----~----~------~----~------~--~---
